favicons

src/main.rs

@@ -113,8 +113,8 @@ async fn main() -> std::io::Result<()> {
             .configure(v1::services)
             .configure(widget::services)
             .configure(docs::services)
-            .configure(static_assets::services)
             .configure(pages::services)
+            .configure(static_assets::services)
             .app_data(get_json_err())
     })
     .bind(SETTINGS.server.get_ip())

src/static_assets/filemap.rs

@@ -0,0 +1,52 @@
+/*
+* Copyright (C) 2021  Aravinth Manivannan <realaravinth@batsense.net>
+*
+* This program is free software: you can redistribute it and/or modify
+* it under the terms of the GNU Affero General Public License as
+* published by the Free Software Foundation, either version 3 of the
+* License, or (at your option) any later version.
+*
+* This program is distributed in the hope that it will be useful,
+* but WITHOUT ANY WARRANTY; without even the implied warranty of
+* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+* GNU Affero General Public License for more details.
+*
+* You should have received a copy of the GNU Affero General Public License
+* along with this program.  If not, see <https://www.gnu.org/licenses/>.
+*/
+use cache_buster::Files;
+
+pub struct FileMap {
+    pub files: Files,
+}
+
+impl FileMap {
+    pub fn new() -> Self {
+        let map = include_str!("../cache_buster_data.json");
+        let files = Files::new(&map);
+        Self { files }
+    }
+    pub fn get<'a>(&'a self, path: &'a str) -> Option<&'a str> {
+        // let file_path = self.files.get(path);
+        let file_path = self.files.get_full_path(path);
+
+        if file_path.is_some() {
+            let file_path = &file_path.unwrap()[1..];
+            return Some(file_path);
+        } else {
+            return None;
+        }
+    }
+}
+
+#[cfg(test)]
+mod tests {
+
+    #[test]
+    fn filemap_works() {
+        let files = super::FileMap::new();
+        let css = files.get("./static-assets/bundle/bundle.css").unwrap();
+        println!("{}", css);
+        assert!(css.contains("/static/bundle/bundle"));
+    }
+}

src/static_assets/mod.rs

@@ -0,0 +1,26 @@
+/*
+* Copyright (C) 2021  Aravinth Manivannan <realaravinth@batsense.net>
+*
+* This program is free software: you can redistribute it and/or modify
+* it under the terms of the GNU Affero General Public License as
+* published by the Free Software Foundation, either version 3 of the
+* License, or (at your option) any later version.
+*
+* This program is distributed in the hope that it will be useful,
+* but WITHOUT ANY WARRANTY; without even the implied warranty of
+* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+* GNU Affero General Public License for more details.
+*
+* You should have received a copy of the GNU Affero General Public License
+* along with this program.  If not, see <https://www.gnu.org/licenses/>.
+*/
+
+pub mod filemap;
+pub mod static_files;
+
+pub use filemap::FileMap;
+
+pub fn services(cfg: &mut actix_web::web::ServiceConfig) {
+    cfg.service(static_files::static_files);
+    cfg.service(static_files::favicons);
+}

src/static_assets/static_files.rs

@@ -18,7 +18,7 @@ use std::borrow::Cow;
 
 use actix_web::body::Body;
 use actix_web::{get, http::header, web, HttpResponse, Responder};
-use cache_buster::Files;
+use log::debug;
 use mime_guess::from_path;
 use rust_embed::RustEmbed;
 
@@ -28,7 +28,7 @@ use crate::CACHE_AGE;
 #[folder = "static/"]
 struct Asset;
 
-pub fn handle_embedded_file(path: &str) -> HttpResponse {
+fn handle_assets(path: &str) -> HttpResponse {
     match Asset::get(path) {
         Some(content) => {
             let body: Body = match content {
@@ -48,37 +48,41 @@ pub fn handle_embedded_file(path: &str) -> HttpResponse {
 }
 
 #[get("/static/{_:.*}")]
-async fn dist(path: web::Path<String>) -> impl Responder {
-    handle_embedded_file(&path.0)
+pub async fn static_files(path: web::Path<String>) -> impl Responder {
+    handle_assets(&path.0)
 }
 
-pub fn services(cfg: &mut web::ServiceConfig) {
-    cfg.service(dist);
-}
 
-pub struct FileMap {
-    files: Files,
-}
 
-impl FileMap {
-    pub fn new() -> Self {
-        let map = include_str!("cache_buster_data.json");
-        let files = Files::new(&map);
-        Self { files }
-    }
-    pub fn get<'a>(&'a self, path: &'a str) -> Option<&'a str> {
-        // let file_path = self.files.get(path);
-        let file_path = self.files.get_full_path(path);
+#[derive(RustEmbed)]
+#[folder = "static-assets/favicons/"]
+struct Favicons;
 
-        if file_path.is_some() {
-            let file_path = &file_path.unwrap()[1..];
-            return Some(file_path);
-        } else {
-            return None;
+fn handle_favicons(path: &str) -> HttpResponse {
+    match Favicons::get(path) {
+        Some(content) => {
+            let body: Body = match content {
+                Cow::Borrowed(bytes) => bytes.into(),
+                Cow::Owned(bytes) => bytes.into(),
+            };
+
+            HttpResponse::Ok()
+                .set(header::CacheControl(vec![header::CacheDirective::MaxAge(
+                    CACHE_AGE,
+                )]))
+                .content_type(from_path(path).first_or_octet_stream().as_ref())
+                .body(body)
         }
+        None => HttpResponse::NotFound().body("404 Not Found"),
     }
 }
 
+#[get("/{file}")]
+pub async fn favicons(path: web::Path<String>) -> impl Responder {
+    debug!("searching favicons");
+    handle_favicons(&path.0)
+}
+
 #[cfg(test)]
 mod tests {
     use actix_web::http::StatusCode;
@@ -86,10 +90,11 @@ mod tests {
 
     use super::*;
     use crate::*;
+    use crate::tests::*;
 
     #[actix_rt::test]
     async fn static_assets_work() {
-        let mut app = test::init_service(App::new().configure(services)).await;
+        let mut app = get_app!().await;
 
         let resp = test::call_service(
             &mut app,
@@ -99,11 +104,21 @@ mod tests {
         assert_eq!(resp.status(), StatusCode::OK);
     }
 
-    #[test]
-    fn filemap_works() {
-        let files = super::FileMap::new();
-        let css = files.get("./static-assets/bundle/bundle.css").unwrap();
-        println!("{}", css);
-        assert!(css.contains("/static/bundle/bundle"));
+    #[actix_rt::test]
+    async fn favicons_work() {
+
+        assert!(Favicons::get("favicon.ico").is_some());
+
+        //let mut app = test::init_service(App::new().configure(services)).await;
+        let mut app = get_app!().await;
+
+        let resp = test::call_service(
+            &mut app,
+            test::TestRequest::get().uri("/favicon.ico").to_request(),
+        )
+        .await;
+        assert_eq!(resp.status(), StatusCode::OK);
+
     }
+
 }

src/tests/mod.rs

@@ -48,6 +48,21 @@ macro_rules! post_request {
 
 #[macro_export]
 macro_rules! get_app {
+    () => {
+    test::init_service(
+            App::new()
+                .wrap(get_identity_service())
+                .wrap(actix_middleware::NormalizePath::new(
+                    actix_middleware::normalize::TrailingSlash::Trim,
+                ))
+                .configure(crate::api::v1::services)
+                .configure(crate::widget::services)
+                .configure(crate::docs::services)
+                .configure(crate::pages::services)
+                .configure(crate::static_assets::services)
+        )
+
+    };
     ($data:expr) => {
         test::init_service(
             App::new()
@@ -55,9 +70,11 @@ macro_rules! get_app {
                 .wrap(actix_middleware::NormalizePath::new(
                     actix_middleware::normalize::TrailingSlash::Trim,
                 ))
-                .configure(crate::api::v1::pow::services)
                 .configure(crate::api::v1::services)
+                .configure(crate::widget::services)
+                .configure(crate::docs::services)
                 .configure(crate::pages::services)
+                .configure(crate::static_assets::services)
                 .data($data.clone()),
         )
     };