clippy fixes and env docs update

src/api/v1/account/password.rs

@@ -1,19 +1,19 @@
 /*
-* Copyright (C) 2021  Aravinth Manivannan <realaravinth@batsense.net>
-*
-* This program is free software: you can redistribute it and/or modify
-* it under the terms of the GNU Affero General Public License as
-* published by the Free Software Foundation, either version 3 of the
-* License, or (at your option) any later version.
-*
-* This program is distributed in the hope that it will be useful,
-* but WITHOUT ANY WARRANTY; without even the implied warranty of
-* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-* GNU Affero General Public License for more details.
-*
-* You should have received a copy of the GNU Affero General Public License
-* along with this program.  If not, see <https://www.gnu.org/licenses/>.
-*/
+ * Copyright (C) 2021  Aravinth Manivannan <realaravinth@batsense.net>
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License as
+ * published by the Free Software Foundation, either version 3 of the
+ * License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with this program.  If not, see <https://www.gnu.org/licenses/>.
+ */
 use actix_identity::Identity;
 use actix_web::{web, HttpResponse, Responder};
 use argon2_creds::Config;
@@ -166,7 +166,7 @@ mod tests {
 
         bad_post_req_test(
             NAME,
-            &new_password,
+            new_password,
             ROUTES.account.update_password,
             &update_password,
             ServiceError::PasswordsDontMatch,
@@ -181,7 +181,7 @@ mod tests {
 
         bad_post_req_test(
             NAME,
-            &new_password,
+            new_password,
             ROUTES.account.update_password,
             &update_password,
             ServiceError::WrongPassword,

src/api/v1/auth.rs

@@ -78,7 +78,7 @@ pub mod runners {
         use sqlx::Error::RowNotFound;
 
         let verify = |stored: &str, received: &str| {
-            if Config::verify(&stored, &received)? {
+            if Config::verify(stored, received)? {
                 Ok(())
             } else {
                 Err(ServiceError::WrongPassword)
@@ -144,7 +144,7 @@ pub mod runners {
         let hash = data.creds.password(&payload.password)?;
 
         if let Some(email) = &payload.email {
-            data.creds.email(&email)?;
+            data.creds.email(email)?;
         }
 
         let mut secret;

src/api/v1/mcaptcha/levels.rs

@@ -301,7 +301,7 @@ mod tests {
 
         let add_token_resp = test::call_service(
             &app,
-            post_request!(&update_level, &ROUTES.levels.update)
+            post_request!(&update_level, ROUTES.levels.update)
                 .cookie(cookies.clone())
                 .to_request(),
         )

src/static_assets/filemap.rs

@@ -24,7 +24,7 @@ impl FileMap {
     #[allow(clippy::new_without_default)]
     pub fn new() -> Self {
         let map = include_str!("../cache_buster_data.json");
-        let files = Files::new(&map);
+        let files = Files::new(map);
         Self { files }
     }
     pub fn get<'a>(&'a self, path: &'a str) -> Option<&'a str> {

src/stats/fetch.rs

@@ -72,7 +72,7 @@ impl StatsUnixTimestamp {
 
     /// featch PoWConfig confirms
     #[inline]
-    fn unix_timestamp(dates: &Vec<Date>) -> Vec<i64> {
+    fn unix_timestamp(dates: &[Date]) -> Vec<i64> {
         let mut res: Vec<i64> = Vec::with_capacity(dates.len());
 
         dates
@@ -193,7 +193,7 @@ mod tests {
         let (_, _, _, token_key) = add_levels_util(NAME, PASSWORD).await;
         let key = token_key.key.clone();
 
-        let stats = Stats::new(&NAME, &key, &data.db).await.unwrap();
+        let stats = Stats::new(NAME, &key, &data.db).await.unwrap();
 
         assert_eq!(stats.config_fetches.len(), 0);
         assert_eq!(stats.solves.len(), 0);
@@ -205,7 +205,7 @@ mod tests {
             record_confirm(&key, &data.db)
         );
 
-        let stats = Stats::new(&NAME, &key, &data.db).await.unwrap();
+        let stats = Stats::new(NAME, &key, &data.db).await.unwrap();
 
         assert_eq!(stats.config_fetches.len(), 1);
         assert_eq!(stats.solves.len(), 1);