mirror of
https://github.com/mCaptcha/mCaptcha.git
synced 2026-02-11 10:05:41 +00:00
SUMMARY
The test suite was spinning up way too many database connections that what's
strictly needed and so the test suite was failing with[0]:
code: "53300", message: "sorry, too many clients already"
EXPERIMENTS
Tried sharing database connection pool across all tests with
async_once[0] but faced:
- IO errors
The connections were probably getting dropped in between tests
- actix Actor errors
The actor was probably not getting initialized before a
a reference to the async_once initialized app
context(crate::data::Data) is retrieved and used
FIX
crate::tests was spinning up an App context
instance(crate::data::Data) for most utility functions, which was
unnecessarily excessive.
Each test now creates an instance of the application context at the
beginning and shared a reference with all test utility functions. So
number of database connections/app context instance = number of unit
tests.
[0]: permanently fixes #22
[1]: https://docs.rs/async_once/latest/async_once/
166 lines
5.0 KiB
Rust
166 lines
5.0 KiB
Rust
/*
|
|
* Copyright (C) 2022 Aravinth Manivannan <realaravinth@batsense.net>
|
|
*
|
|
* This program is free software: you can redistribute it and/or modify
|
|
* it under the terms of the GNU Affero General Public License as
|
|
* published by the Free Software Foundation, either version 3 of the
|
|
* License, or (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU Affero General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU Affero General Public License
|
|
* along with this program. If not, see <https://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
use actix_identity::Identity;
|
|
use actix_web::{HttpResponse, Responder};
|
|
use serde::{Deserialize, Serialize};
|
|
use sqlx::types::time::OffsetDateTime;
|
|
|
|
use crate::errors::*;
|
|
use crate::AppData;
|
|
|
|
pub struct Notification {
|
|
pub name: Option<String>,
|
|
pub heading: Option<String>,
|
|
pub message: Option<String>,
|
|
pub received: Option<OffsetDateTime>,
|
|
pub id: Option<i32>,
|
|
}
|
|
|
|
#[derive(Deserialize, Serialize)]
|
|
pub struct NotificationResp {
|
|
pub name: String,
|
|
pub heading: String,
|
|
pub message: String,
|
|
pub received: i64,
|
|
pub id: i32,
|
|
}
|
|
|
|
impl From<Notification> for NotificationResp {
|
|
fn from(n: Notification) -> Self {
|
|
NotificationResp {
|
|
name: n.name.unwrap(),
|
|
heading: n.heading.unwrap(),
|
|
received: n.received.unwrap().unix_timestamp(),
|
|
id: n.id.unwrap(),
|
|
message: n.message.unwrap(),
|
|
}
|
|
}
|
|
}
|
|
|
|
/// route handler that gets all unread notifications
|
|
#[my_codegen::get(
|
|
path = "crate::V1_API_ROUTES.notifications.get",
|
|
wrap = "crate::api::v1::get_middleware()"
|
|
)]
|
|
pub async fn get_notification(
|
|
data: AppData,
|
|
id: Identity,
|
|
) -> ServiceResult<impl Responder> {
|
|
let receiver = id.identity().unwrap();
|
|
// TODO handle error where payload.to doesnt exist
|
|
|
|
let mut notifications = runner::get_notification(&data, &receiver).await?;
|
|
let resp: Vec<NotificationResp> = notifications
|
|
.drain(0..)
|
|
.map(|x| {
|
|
let y: NotificationResp = x.into();
|
|
y
|
|
})
|
|
.collect();
|
|
|
|
Ok(HttpResponse::Ok().json(resp))
|
|
}
|
|
|
|
pub mod runner {
|
|
use super::*;
|
|
pub async fn get_notification(
|
|
data: &AppData,
|
|
receiver: &str,
|
|
) -> ServiceResult<Vec<Notification>> {
|
|
// TODO handle error where payload.to doesnt exist
|
|
|
|
let notifications = sqlx::query_file_as!(
|
|
Notification,
|
|
"src/api/v1/notifications/get_all_unread.sql",
|
|
&receiver
|
|
)
|
|
.fetch_all(&data.db)
|
|
.await?;
|
|
|
|
Ok(notifications)
|
|
}
|
|
}
|
|
|
|
#[cfg(test)]
|
|
pub mod tests {
|
|
use actix_web::http::StatusCode;
|
|
use actix_web::test;
|
|
|
|
use super::*;
|
|
use crate::api::v1::notifications::add::AddNotification;
|
|
use crate::tests::*;
|
|
use crate::*;
|
|
|
|
#[actix_rt::test]
|
|
pub async fn notification_get_works() {
|
|
const NAME1: &str = "notifuser12";
|
|
const NAME2: &str = "notiuser22";
|
|
const PASSWORD: &str = "longpassworddomain";
|
|
const EMAIL1: &str = "testnotification12@a.com";
|
|
const EMAIL2: &str = "testnotification22@a.com";
|
|
const HEADING: &str = "testing notifications get";
|
|
const MESSAGE: &str = "testing notifications get message";
|
|
|
|
let data = crate::data::Data::new().await;
|
|
let data = &data;
|
|
|
|
delete_user(data, NAME1).await;
|
|
delete_user(data, NAME2).await;
|
|
|
|
register_and_signin(data, NAME1, EMAIL1, PASSWORD).await;
|
|
register_and_signin(data, NAME2, EMAIL2, PASSWORD).await;
|
|
let (_creds, signin_resp) = signin(data, NAME1, PASSWORD).await;
|
|
let (_creds2, signin_resp2) = signin(data, NAME2, PASSWORD).await;
|
|
let cookies = get_cookie!(signin_resp);
|
|
let cookies2 = get_cookie!(signin_resp2);
|
|
let app = get_app!(data).await;
|
|
|
|
let msg = AddNotification {
|
|
to: NAME2.into(),
|
|
heading: HEADING.into(),
|
|
message: MESSAGE.into(),
|
|
};
|
|
|
|
let send_notification_resp = test::call_service(
|
|
&app,
|
|
post_request!(&msg, V1_API_ROUTES.notifications.add)
|
|
.cookie(cookies.clone())
|
|
.to_request(),
|
|
)
|
|
.await;
|
|
assert_eq!(send_notification_resp.status(), StatusCode::OK);
|
|
|
|
let get_notifications_resp = test::call_service(
|
|
&app,
|
|
test::TestRequest::get()
|
|
.uri(V1_API_ROUTES.notifications.get)
|
|
.cookie(cookies2.clone())
|
|
.to_request(),
|
|
)
|
|
.await;
|
|
assert_eq!(get_notifications_resp.status(), StatusCode::OK);
|
|
|
|
let mut notifications: Vec<NotificationResp> =
|
|
test::read_body_json(get_notifications_resp).await;
|
|
let notification = notifications.pop().unwrap();
|
|
assert_eq!(notification.name, NAME1);
|
|
assert_eq!(notification.message, MESSAGE);
|
|
assert_eq!(notification.heading, HEADING);
|
|
}
|
|
}
|